Skip to content

Conversation

@mrlockstar
Copy link
Contributor

@mrlockstar mrlockstar commented Dec 3, 2025

Description

We need to configure a container probe (liveness/readiness) for our Azure Container Apps deployment.

By default, the web application should only have a heath probe if the variable probe_path is set.

If probe_path is null then it's disabled.

Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.

image image

Please look for container app manbrs-web-pr-801 for evidence. Note I have observed the container for 10 plus minutes and have been able to log in and off the container without it crashing.

Please note that I have reverted back the TERRAFORM_MODULES_REF to main but originally tested using branch DTOSS-11646-Setup-Container-Apps-container-probes.

Jira link

Review notes

Review checklist

  • Check database queries are correctly scoped to current_provider

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

The review app is available at this URL:
https://pr-801.manage-breast-screening.non-live.screening.nhs.uk
You must authenticate with HTTP basic authentication. Ask the team for credentials.

@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from 94dfb9c to e4fc3c5 Compare December 3, 2025 23:20
@mrlockstar mrlockstar removed the deploy label Dec 3, 2025
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from e4fc3c5 to d80f980 Compare December 3, 2025 23:22
@mrlockstar mrlockstar marked this pull request as ready for review December 3, 2025 23:23
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from d80f980 to f0a0113 Compare December 3, 2025 23:35
@mrlockstar mrlockstar requested review from a team December 3, 2025 23:35
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from f0a0113 to ca8a76b Compare December 3, 2025 23:35
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from 6bb81fe to da11892 Compare December 5, 2025 17:00
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from 32a897a to 07b91d4 Compare December 8, 2025 13:49
@mrlockstar mrlockstar removed the deploy label Dec 8, 2025
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch 4 times, most recently from 481297c to c99407b Compare December 8, 2025 14:01
We need to configure a container probe (liveness/readiness) for our Azure Container Apps deployment.
By default, the web application should only have a heath probe if the variable probe_path is set.
If probe_path is null then it's disabled.
Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.
@mrlockstar mrlockstar force-pushed the DTOSS-11646-Setup-Container-Apps-container-probes branch from c99407b to 3cf0e0b Compare December 8, 2025 14:01
@mrlockstar mrlockstar merged commit fa75177 into main Dec 9, 2025
12 checks passed
@mrlockstar mrlockstar deleted the DTOSS-11646-Setup-Container-Apps-container-probes branch December 9, 2025 12:31
@mrlockstar mrlockstar restored the DTOSS-11646-Setup-Container-Apps-container-probes branch December 30, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants