generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
DTOSS-11646: Setup Container Apps container probes #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrlockstar
merged 1 commit into
main
from
DTOSS-11646-Setup-Container-Apps-container-probes
Dec 9, 2025
Merged
DTOSS-11646: Setup Container Apps container probes #801
mrlockstar
merged 1 commit into
main
from
DTOSS-11646-Setup-Container-Apps-container-probes
Dec 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b137835 to
e81f000
Compare
|
The review app is available at this URL: |
94dfb9c to
e4fc3c5
Compare
e4fc3c5 to
d80f980
Compare
d80f980 to
f0a0113
Compare
f0a0113 to
ca8a76b
Compare
6bb81fe to
da11892
Compare
32a897a to
07b91d4
Compare
481297c to
c99407b
Compare
We need to configure a container probe (liveness/readiness) for our Azure Container Apps deployment. By default, the web application should only have a heath probe if the variable probe_path is set. If probe_path is null then it's disabled. Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.
c99407b to
3cf0e0b
Compare
saliceti
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to configure a container probe (liveness/readiness) for our Azure Container Apps deployment.
By default, the web application should only have a heath probe if the variable probe_path is set.
If probe_path is null then it's disabled.
Please note that we cannot do this for the Postgres DB container as there is no Django / restful interface to implement.
Please look for container app manbrs-web-pr-801 for evidence. Note I have observed the container for 10 plus minutes and have been able to log in and off the container without it crashing.
Please note that I have reverted back the TERRAFORM_MODULES_REF to main but originally tested using branch DTOSS-11646-Setup-Container-Apps-container-probes.
Jira link
Review notes
Review checklist